netdev - Re: [PATCH v2 net-next 1/2] tcp: uniform the set up of sockets after successful connection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171005.211043.2125306522607618573.davem@davemloft.net>
Date:   Thu, 05 Oct 2017 21:10:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     weiwan@...gle.com
Cc:     netdev@...r.kernel.org, ycheng@...gle.com, ncardwell@...gle.com,
        edumazet@...gle.com
Subject: Re: [PATCH v2 net-next 1/2] tcp: uniform the set up of sockets
 after successful connection

From: Wei Wang <weiwan@...gle.com>
Date: Wed,  4 Oct 2017 10:03:44 -0700

> From: Wei Wang <weiwan@...gle.com>
> 
> Currently in the TCP code, the initialization sequence for cached
> metrics, congestion control, BPF, etc, after successful connection
> is very inconsistent. This introduces inconsistent bevhavior and is
> prone to bugs. The current call sequence is as follows:
 ...
> This commit uniforms the above functions to have the following sequence:
>         tcp_mtup_init(sk);
>         icsk->icsk_af_ops->rebuild_header(sk);
>         tcp_init_metrics(sk);
>         tcp_call_bpf(sk, BPF_SOCK_OPS_ACTIVE/PASSIVE_ESTABLISHED_CB);
>         tcp_init_congestion_control(sk);
>         tcp_init_buffer_space(sk);
> This sequence is the same as the (1) active case. We pick this sequence
> because this order correctly allows BPF to override the settings
> including congestion control module and initial cwnd, etc from
> the route, and then allows the CC module to see those settings.
> 
> Suggested-by: Neal Cardwell <ncardwell@...gle.com>
> Tested-by: Neal Cardwell <ncardwell@...gle.com>
> Signed-off-by: Wei Wang <weiwan@...gle.com>
> Acked-by: Neal Cardwell <ncardwell@...gle.com>
> Acked-by: Yuchung Cheng <ycheng@...gle.com>
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Nice change, applied, thanks.