netdev - Re: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171007.003134.133270352885522371.davem@davemloft.net>
Date:   Sat, 07 Oct 2017 00:31:34 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     ncardwell@...gle.com, ycheng@...gle.com, netdev@...r.kernel.org,
        eric.dumazet@...il.com
Subject: Re: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit
 queue

From: Eric Dumazet <edumazet@...gle.com>
Date: Thu,  5 Oct 2017 22:21:20 -0700

> This patch series implement RB-tree based retransmit queue for TCP,
> to better match modern BDP.

Indeed, there was a lot of resistence to this due to the overhead
for small retransmit queue sizes, but with today's scale this is
long overdue.

So, series applied, nice work!

Maybe we can look into dynamic schemes where when the queue never
goes over N entries we elide the rbtree and use a list.  I'm not
so sure how practical that would be.

Thanks!