netdev - Re: [RESEND PATCH 7/7] net: qrtr: Support decoding incoming v2 packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171005.180539.381799694621402344.davem@davemloft.net>
Date:   Thu, 05 Oct 2017 18:05:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     bjorn.andersson@...aro.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, clew@...eaurora.org
Subject: Re: [RESEND PATCH 7/7] net: qrtr: Support decoding incoming v2
 packets

From: Bjorn Andersson <bjorn.andersson@...aro.org>
Date: Wed,  4 Oct 2017 20:51:05 -0700

> +/**
> + * struct qrtr_hdr_v2 - (I|R)PCrouter packet header later versions
> + * @version: protocol version
> + * @type: packet type; one of QRTR_TYPE_*
> + * @flags: bitmask of QRTR_FLAGS_*
> + * @optlen: length of optional header data
> + * @size: length of packet, excluding this header and optlen
> + * @src_node_id: source node
> + * @src_port_id: source port
> + * @dst_node_id: destination node
> + * @dst_port_id: destination port
> + */
> +struct qrtr_hdr_v2 {
> +	u8 version;
> +	u8 type;
> +	u8 flags;
> +	u8 optlen;
> +	__le32 size;
> +	__le16 src_node_id;
> +	__le16 src_port_id;
> +	__le16 dst_node_id;
> +	__le16 dst_port_id;
> +} __packed;

__packed should be only used when it is provably necessary, and it
should not be needed here.