netdev - Re: [PATCH] ipv6: fix net.ipv6.conf.all.accept

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171007.231159.210016932080491947.davem@davemloft.net>
Date:   Sat, 07 Oct 2017 23:11:59 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     mcroce@...hat.com
Cc:     netdev@...r.kernel.org, ek@...gle.com
Subject: Re: [PATCH] ipv6: fix net.ipv6.conf.all.accept_dad behaviour for
 real

From: Matteo Croce <mcroce@...hat.com>
Date: Thu,  5 Oct 2017 19:03:05 +0200

> Commit 35e015e1f577 ("ipv6: fix net.ipv6.conf.all interface DAD handlers")
> was intended to affect accept_dad flag handling in such a way that
> DAD operation and mode on a given interface would be selected
> according to the maximum value of conf/{all,interface}/accept_dad.
> 
> However, addrconf_dad_begin() checks for particular cases in which we
> need to skip DAD, and this check was modified in the wrong way.
> 
> Namely, it was modified so that, if the accept_dad flag is 0 for the
> given interface *or* for all interfaces, DAD would be skipped.
> 
> We have instead to skip DAD if accept_dad is 0 for the given interface
> *and* for all interfaces.
> 
> Fixes: 35e015e1f577 ("ipv6: fix net.ipv6.conf.all interface DAD handlers")
> Acked-by: Stefano Brivio <sbrivio@...hat.com>
> Signed-off-by: Matteo Croce <mcroce@...hat.com>

Applied.