lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 08 Oct 2017 10:00:13 -0700 (PDT) From: David Miller <davem@...emloft.net> To: yamada.masahiro@...ionext.com Cc: linux-kernel@...r.kernel.org, tglx@...utronix.de, akpm@...ux-foundation.org, abbotti@....co.uk, mingo@...nel.org, torvalds@...ux-foundation.org, linux-rdma@...r.kernel.org, yishaih@...lanox.com, tariqt@...lanox.com, netdev@...r.kernel.org Subject: Re: [PATCH 10/12] net/mlx4: replace <linux/radix-tree.h> with <linux/radix-tree-root.h> From: Masahiro Yamada <yamada.masahiro@...ionext.com> Date: Mon, 9 Oct 2017 01:10:11 +0900 > The headers > - include/linux/mlx4/device.h > - drivers/net/ethernet/mellanox/mlx4/mlx4.h > require the definition of struct radix_tree_root, but do not need to > know anything about other radix tree stuff. > > Include <linux/radix-tree-root.h> instead of <linux/radix-tree.h> to > reduce the header dependency. > > While we are here, let's add missing <linux/radix-tree.h> where > radix tree accessors are used. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com> Honestly this makes things more complicated. The driver was trying to consolidate all of the header needs by including them all in one place, the main driver header. Now you're including headers in several different files. I really don't like the results of this change and would ask you to reconsider. Just add both radix-tree-root.h _and_ radix-tree.h to mlx4.h and leave the rest of the driver alone.
Powered by blists - more mailing lists