netdev - Re: [PATCH v3 3/3] net: phy: Change error to EINVAL for invalid MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bafce8fe-ed85-bfce-3231-ec61eb99e668@gmail.com>
Date:   Mon, 9 Oct 2017 09:47:14 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Dan Murphy <dmurphy@...com>, andrew@...n.ch
Cc:     netdev@...r.kernel.org, Woojung.Huh@...rochip.com, afd@...com
Subject: Re: [PATCH v3 3/3] net: phy: Change error to EINVAL for invalid MAC

On 10/09/2017 05:03 AM, Dan Murphy wrote:
> Change the return error code to EINVAL if the MAC
> address is not valid in the set_wol function.

Looks fine to me, since you are respining, do you mind using "net: phy:
at803x:  Change error to EINVAL for invalid MAC" as a subject to further
specify what this is about?

Thanks!

> 
> Signed-off-by: Dan Murphy <dmurphy@...com>
> ---
> 
> v3 - No changes made
> v2 - There was no v1 on this patch this is new.
> 
>  drivers/net/phy/at803x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index c1e52b9dc58d..5f93e6add563 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -167,7 +167,7 @@ static int at803x_set_wol(struct phy_device *phydev,
>  		mac = (const u8 *) ndev->dev_addr;
>  
>  		if (!is_valid_ether_addr(mac))
> -			return -EFAULT;
> +			return -EINVAL;
>  
>  		for (i = 0; i < 3; i++) {
>  			phy_write(phydev, AT803X_MMD_ACCESS_CONTROL,
> 


-- 
Florian