netdev - Re: ipsec: Fix dst leak in xfrm_bundle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171011115430.GL3149@secunet.com>
Date:   Wed, 11 Oct 2017 13:54:30 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     David Miller <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>
Subject: Re: ipsec: Fix dst leak in xfrm_bundle_create().

On Tue, Oct 10, 2017 at 08:59:38PM -0700, David Miller wrote:
> 
> If we cannot find a suitable inner_mode value, we will leak
> the currently allocated 'xdst'.
> 
> The fix is to make sure it is linked into the chain before
> erroring out.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
> 
> Steffen, I found this via visual inspection.  Please double check my
> work before applying this :-)

Looks good. Patch applied, thanks David!