netdev - Re: [RFC net-next 4/4] mlxsw: spectrum_router: Add extack message for RIF and VRF overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171011151043.GA13708@splinter>
Date:   Wed, 11 Oct 2017 18:10:43 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, idosch@...lanox.com,
        kjlx@...pleofstupid.com
Subject: Re: [RFC net-next 4/4] mlxsw: spectrum_router: Add extack message
 for RIF and VRF overflow

On Wed, Oct 11, 2017 at 09:07:20AM -0600, David Ahern wrote:
> On 10/11/17 8:13 AM, Ido Schimmel wrote:
> > On Tue, Oct 10, 2017 at 09:41:05AM -0700, David Ahern wrote:
> >>  static struct mlxsw_sp_vr *mlxsw_sp_vr_create(struct mlxsw_sp *mlxsw_sp,
> >> -					      u32 tb_id)
> >> +					      u32 tb_id,
> >> +					      struct netlink_ext_ack *extack)
> >>  {
> >>  	struct mlxsw_sp_vr *vr;
> >>  	int err;
> >>  
> >>  	vr = mlxsw_sp_vr_find_unused(mlxsw_sp);
> >> -	if (!vr)
> >> +	if (!vr) {
> >> +		NL_SET_ERR_MSG(extack, "spectrum: Exceeded number of supported VRF");
> > 
> > Maybe:
> > "spectrum: Exceeded number of supported VRF devices"
> 
> In this context the overflow is virtual routers in spectrum as opposed
> to VRF devices in the kernel context. The existence of the VRF device
> has no bearing until a port is enslaved to it.
> 
> How about:
>  "spectrum: Exceeded number of supported virtual routers"

OK.