netdev - Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wp42qe9y.fsf@kamboji.qca.qualcomm.com>
Date:   Wed, 11 Oct 2017 08:28:42 +0000
From:   Kalle Valo <kvalo@....qualcomm.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
CC:     Jia-Ju Bai <baijiaju1990@....com>,
        "k.eugene.e@...il.com" <k.eugene.e@...il.com>,
        "wcn36xx@...ts.infradead.org" <wcn36xx@...ts.infradead.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in
 wcn36xx_bss_info_changed

Bjorn Andersson <bjorn.andersson@...aro.org> writes:

> On Sun 08 Oct 06:06 PDT 2017, Jia-Ju Bai wrote:
>
>> No rcu_read_lock is called, but rcu_read_unlock is still called.
>> Thus rcu_read_unlock should be removed.
>> 
>
> Thanks, not sure how I could miss that one. Kalle can you please include
> this in a v4.14-rc pull request?
>
>
> :
>
> Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configuration")
>
>> Signed-off-by: Jia-Ju Bai <baijiaju1990@....com>
>
> Acked-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Ok, I'll queue this to 4.14.

-- 
Kalle Valo