netdev - RE: [PATCH v2] xdp: Sample xdp program implementing ip forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD0090EEE@AcuExch.aculab.com>
Date:   Wed, 11 Oct 2017 10:08:21 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Jesper Dangaard Brouer' <brouer@...hat.com>,
        Christina Jacob <christina.jacob.koikara@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "Sunil.Goutham@...ium.com" <Sunil.Goutham@...ium.com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "dsahern@...il.com" <dsahern@...il.com>,
        Christina Jacob <Christina.Jacob@...ium.com>
Subject: RE: [PATCH v2] xdp: Sample xdp program implementing ip forward

From: Jesper Dangaard Brouer
> Sent: 10 October 2017 20:06
...
> > +		int src_ip = 0, dest_ip = 0;
...
> > +			key4.b8[4] = dest_ip % 0x100;
> > +			key4.b8[5] = (dest_ip >> 8) % 0x100;
> > +			key4.b8[6] = (dest_ip >> 16) % 0x100;
> > +			key4.b8[7] = (dest_ip >> 24) % 0x100;

Do you really want signed remainders done here?

	David