[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20171012141548.GE14672@nanopsycho>
Date: Thu, 12 Oct 2017 16:15:48 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Steve Lin <steven.lin1@...adcom.com>
Cc: netdev@...r.kernel.org, jiri@...lanox.com, davem@...emloft.net,
michael.chan@...adcom.com, linux-pci@...r.kernel.org,
linville@...driver.com, gospo@...adcom.com
Subject: Re: [RFC 1/3] devlink: Add config parameter get/set operations
Thu, Oct 12, 2017 at 03:34:20PM CEST, steven.lin1@...adcom.com wrote:
>+
>+ /* When config doesn't take effect until next reboot (config
>+ * just changed NVM which isn't read until boot, for example),
>+ * this attribute should be set by the driver.
>+ */
>+ DEVLINK_ATTR_RESTART_REQUIRED, /* u8 */
>+
I think it would be nice to return this information as a part of retply
to set message - extack
Also, we need to expose to the user the original value (currently being
used) and the new one (to be used after driver re-instatiation)
Powered by blists - more mailing lists