netdev - RE: [PATCH net] net: dsa: mv88e6060: fix switch MAC address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9235D6609DB808459E95D78E17F2E43D40B519C6@CHN-SV-EXMX02.mchp-main.com>
Date:   Fri, 13 Oct 2017 19:09:22 +0000
From:   <Woojung.Huh@...rochip.com>
To:     <vivien.didelot@...oirfairelinux.com>, <netdev@...r.kernel.org>
CC:     <linux-kernel@...r.kernel.org>, <kernel@...oirfairelinux.com>,
        <davem@...emloft.net>, <f.fainelli@...il.com>, <andrew@...n.ch>,
        <David.Laight@...LAB.COM>
Subject: RE: [PATCH net] net: dsa: mv88e6060: fix switch MAC address

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-
> owner@...r.kernel.org] On Behalf Of Vivien Didelot
> Sent: Friday, October 13, 2017 1:39 PM
> To: netdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org; kernel@...oirfairelinux.com; David S.
> Miller; Florian Fainelli; Andrew Lunn; David Laight; Vivien Didelot
> Subject: [PATCH net] net: dsa: mv88e6060: fix switch MAC address
> 
> The 88E6060 Ethernet switch always transmits the multicast bit of the
> switch MAC address as a zero. It re-uses the corresponding bit 8 of the
> register "Switch MAC Address Register Bytes 0 & 1" for "DiffAddr".
> 
> If the "DiffAddr" bit is 0, then all ports transmit the same source
> address. If it is set to 1, then bit 2:0 are used for the port number.
> 
> The mv88e6060 driver is currently wrongly shifting the MAC address byte
> 0 by 9. To fix this, shift it by 8 as usual and clear its bit 0.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
> ---

Reviewed-by: Woojung Huh <woojung.huh@...rochip.com>

- Woojung