netdev - Re: [PATCH net-next 0/3] sched: act: ife: UAPI checks and performance tweaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171012.222317.639552348780320377.davem@davemloft.net>
Date:   Thu, 12 Oct 2017 22:23:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     aring@...atatu.com
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        netdev@...r.kernel.org, eric.dumazet@...il.com, bjb@...atatu.com
Subject: Re: [PATCH net-next 0/3] sched: act: ife: UAPI checks and
 performance tweaks

From: Alexander Aring <aring@...atatu.com>
Date: Wed, 11 Oct 2017 17:16:05 -0400

> this patch series contains at first a patch which adds a check for
> IFE_ENCODE and IFE_DECODE when a ife act gets created or updated and adding
> handling of these cases only inside the act callback only.
> 
> The second patch use per-cpu counters and move the spinlock around so that
> the spinlock is less being held in act callback.
> 
> The last patch use rcu for update parameters and also move the spinlock for
> the same purpose as in patch 2.
> 
> Notes:
>  - There is still a spinlock around for protecting the metalist and a
>    rw-lock for another list. Should be migrated to a rcu list, ife
>    possible.
> 
>  - I use still dereference in dump callback, so I think what I didn't
>    got was what happened when rcu_assign_pointer will do when rcu read
>    lock is held. I suppose the pointer will be updated, then we don't
>    have any issue here.

Series applied.