lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 Oct 2017 17:09:56 -0700 From: Pravin Shelar <pshelar@....org> To: Andy Zhou <azhou@....org> Cc: Linux Kernel Network Developers <netdev@...r.kernel.org>, Joe Stringer <joe@....org>, Greg Rose <gvrose8192@...il.com> Subject: Re: [net-next RFC 0/4] Openvswitch meter action On Thu, Oct 12, 2017 at 3:38 PM, Andy Zhou <azhou@....org> wrote: > This patch series is the first attempt to add openvswitch > meter support. We have previously experimented with adding > metering support in nftables. However 1) It was not clear > how to expose a named nftables object cleanly, and 2) > the logic that implements metering is quite small, < 100 lines > of code. > > With those two observations, it seems cleaner to add meter > support in the openvswitch module directly. > > Thanks for working on this feature. It looks good to me. I have couple of comments inlined. > Andy Zhou (4): > openvswitch: Add meter netlink definitions > openvswitch: export get_dp() API. > openvswitch: Add meter infrastructure > openvswitch: Add meter action support > > include/uapi/linux/openvswitch.h | 52 ++++ > net/openvswitch/Makefile | 1 + > net/openvswitch/actions.c | 12 + > net/openvswitch/datapath.c | 43 +-- > net/openvswitch/datapath.h | 35 +++ > net/openvswitch/flow_netlink.c | 6 + > net/openvswitch/meter.c | 611 +++++++++++++++++++++++++++++++++++++++ > net/openvswitch/meter.h | 54 ++++ > 8 files changed, 783 insertions(+), 31 deletions(-) > create mode 100644 net/openvswitch/meter.c > create mode 100644 net/openvswitch/meter.h > > -- > 1.8.3.1 >
Powered by blists - more mailing lists