netdev - Re: [PATCH net v2 1/2] ARM: dts: imx: name the interrupts for the fec ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171014185018.GD18578@lunn.ch>
Date:   Sat, 14 Oct 2017 20:50:18 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Troy Kisky <troy.kisky@...ndarydevices.com>
Cc:     shawn.guo@...aro.org, fugang.duan@....com, netdev@...r.kernel.org,
        davem@...emloft.net, fabio.estevam@....com, lznuaa@...il.com
Subject: Re: [PATCH net v2 1/2] ARM: dts: imx: name the interrupts for the
 fec ethernet driver

On Fri, Oct 13, 2017 at 07:09:39PM -0700, Troy Kisky wrote:
> imx7s/imx7d has the ptp interrupt newly added as well.

Hi Troy
 
> For imx7, "int0" is the interrupt for queue 0 and ENET_MII
> "int1" is for queue 1
> "int2" is for queue 2

Thanks for adding this explanation. Please also add it to

Documentation/devicetree/bindings/net/fsl-fec.txt 

>  			fec: ethernet@...88000 {
>  				compatible = "fsl,imx6q-fec";
>  				reg = <0x02188000 0x4000>;
> +				interrupt-names = "int0","ptp";

It is normal to have a space after the ,

   Andrew