[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20171015.140548.812014928035930297.davem@davemloft.net>
Date: Sun, 15 Oct 2017 14:05:48 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: roman@...em.lv
Cc: f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 00/10] korina cleanups/optimizations
From: Roman Yeryomin <roman@...em.lv>
Date: Sun, 15 Oct 2017 19:46:02 +0300
> On 2017-10-15 19:38, Florian Fainelli wrote:
>> On October 15, 2017 9:22:26 AM PDT, Roman Yeryomin <roman@...em.lv>
>> wrote:
>>> TX optimizations have led to ~15% performance increase (35->40Mbps)
>>> in local tx usecase (tested with iperf v3.2).
>> Could you avoid empty commit messages and write a paragraph or two for
>> each commit that explains what and why are you changing? The changes
>> look fine but they lack any explanation.
>
> I thought that short descriptions are already self explanatory and
> just didn't know what to write more.
"Optimize TX handlers."
In what way? Why? How are things improved? Is it measurable?
etc.
Powered by blists - more mailing lists