netdev - RE: [next-queue PATCH v7 4/6] net/sched: Introduce Credit Based Shaper (CBS) qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87376in3lz.fsf@intel.com>
Date:   Mon, 16 Oct 2017 15:13:12 -0700
From:   Vinicius Costa Gomes <vinicius.gomes@...el.com>
To:     David Laight <David.Laight@...LAB.COM>,
        'Ivan Khoronzhuk' <ivan.khoronzhuk@...aro.org>
Cc:     "netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
        "intel-wired-lan\@lists.osuosl.org" 
        <intel-wired-lan@...ts.osuosl.org>,
        "jhs\@mojatatu.com" <jhs@...atatu.com>,
        "xiyou.wangcong\@gmail.com" <xiyou.wangcong@...il.com>,
        "jiri\@resnulli.us" <jiri@...nulli.us>,
        "andre.guedes\@intel.com" <andre.guedes@...el.com>,
        "ivan.briano\@intel.com" <ivan.briano@...el.com>,
        "jesus.sanchez-palencia\@intel.com" 
        <jesus.sanchez-palencia@...el.com>,
        "boon.leong.ong\@intel.com" <boon.leong.ong@...el.com>,
        "richardcochran\@gmail.com" <richardcochran@...il.com>,
        "henrik\@austad.us" <henrik@...tad.us>,
        "levipearson\@gmail.com" <levipearson@...il.com>,
        "rodney.cummings\@ni.com" <rodney.cummings@...com>
Subject: RE: [next-queue PATCH v7 4/6] net/sched: Introduce Credit Based Shaper (CBS) qdisc

Hi David,

David Laight <David.Laight@...LAB.COM> writes:

[...]

>> > index 099bf5528fed..41e349df4bf4 100644
>> > --- a/include/uapi/linux/pkt_sched.h
>> > +++ b/include/uapi/linux/pkt_sched.h
>> > @@ -871,4 +871,22 @@ struct tc_pie_xstats {
>> >  	__u32 maxq;             /* maximum queue size */
>> >  	__u32 ecn_mark;         /* packets marked with ecn*/
>> >  };
>> > +
>> > +/* CBS */
>> > +struct tc_cbs_qopt {
>> > +	__u8 offload;
>
> You probably don't want unnamed padding in a uapi structure.

Yeah, this needs to be fixed.

>
>> > +	__s32 hicredit;
>> > +	__s32 locredit;
>> > +	__s32 idleslope;
>> > +	__s32 sendslope;
>> > +};
>> > +
>> > +enum {
>> > +	TCA_CBS_UNSPEC,
>> > +	TCA_CBS_PARMS,
>> > +	__TCA_CBS_MAX,
>> > +};
>> > +
>> > +#define TCA_CBS_MAX (__TCA_CBS_MAX - 1)
>
> Why not:
> 	TCA_CBS_PARMS,
> 	TCA_CBS_NEXT,
> 	TCA_CBS_MAX = TCA_CBS_NEXT - 1,

The way it is proposed, at least is consistent with the rest of the
file. So, if you don't have any stronger reasons, I'd like to keep it
this way.

>
> ...
> 	David


Cheers,
--
Vinicius