netdev - RE: [patch net 0/4] net/sched: Fix a system panic when deleting filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR0501MB2143AAEF20039638907C1AE1AB4F0@VI1PR0501MB2143.eurprd05.prod.outlook.com>
Date:   Mon, 16 Oct 2017 11:20:52 +0000
From:   Chris Mi <chrism@...lanox.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "lucasb@...atatu.com" <lucasb@...atatu.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [patch net 0/4] net/sched: Fix a system panic when deleting
 filters

Hi Jamal,

> -----Original Message-----
> From: Jamal Hadi Salim [mailto:jhs@...atatu.com]
> Sent: Monday, October 16, 2017 7:06 PM
> To: Chris Mi <chrism@...lanox.com>; netdev@...r.kernel.org
> Cc: lucasb@...atatu.com; xiyou.wangcong@...il.com; jiri@...nulli.us;
> davem@...emloft.net
> Subject: Re: [patch net 0/4] net/sched: Fix a system panic when deleting
> filters
> 
> 
> Hi Chris,
> 
> On 17-10-16 04:31 AM, Chris Mi wrote:
> > If some filters share the same action, when deleting these filters,
> > system may panic. This patchset fixes this issue. And the test case
> > finding this issue is also integrated into tc test suite of selftests.
> >
> 
> I think this would read better if re-worded as:
> ---
> If some filters share the same action, when deleting these filters, it is
> possible to create a system panic. This is because deletions could be
> manipulated by many RCU callbacks at the same time.
> This patch set fixes these issues.
> To reproduce the issue run selftests in patch 3 and 4.
> To test if the issue was fixed, apply patches 1 and 2 and then repeat the tests.
> ------
Done.
> 
> Other than that all look good to me and:
> 
> Acked-by: Jamal Hadi Salim <jhs@...atatu.com>
Done. And thanks for your review.

Thanks,
Chris
> 
> cheers,
> jamal