netdev - Re: [PATCH] net: export netdev_txq_to_tc to allow sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJPRjokxHmj4dYnBQkJ=A4Z-7cMpZ34L+i949tJwUXd2g@mail.gmail.com>
Date:   Tue, 17 Oct 2017 04:21:24 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Henrik Austad <henrik@...tad.us>
Cc:     netdev <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Ahern <dsahern@...il.com>,
        Alexander Duyck <alexander.h.duyck@...el.com>,
        Willem de Bruijn <willemb@...gle.com>,
        John Fastabend <john.fastabend@...il.com>,
        tcharding <me@...in.cc>, LKML <linux-kernel@...r.kernel.org>,
        Henrik Austad <haustad@...co.com>,
        Jesus Sanchez-Palencia <jesus.sanchez-palencia@...el.com>
Subject: Re: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to
 compile as module

On Tue, Oct 17, 2017 at 3:10 AM, Henrik Austad <henrik@...tad.us> wrote:
> In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW
> traffic classes and misc IDs") sch_mqprio started using netdev_txq_to_tc
> to find the correct tc instead of dev->tc_to_txq[]
>
> However, when mqprio is compiled as a module, it cannot resolve the
> symbol, leading to this error:
>
>      ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined!
>
> This adds an EXPORT_SYMBOL() since the other user in the kernel
> (netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a
> sysfs-callback.
>
> Cc: Alexander Duyck <alexander.h.duyck@...el.com>
> Cc: Jesus Sanchez-Palencia <jesus.sanchez-palencia@...el.com>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Henrik Austad <haustad@...co.com>


Reviewed-by: Eric Dumazet <edumazet@...gle.com>