netdev - Re: [PATCH] net: export netdev_txq_to_tc to allow sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171017.170042.1711156550393094740.davem@davemloft.net>
Date:   Tue, 17 Oct 2017 17:00:42 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     henrik@...tad.us
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, daniel@...earbox.net,
        dsahern@...il.com, alexander.h.duyck@...el.com, willemb@...gle.com,
        john.fastabend@...il.com, me@...in.cc,
        linux-kernel@...r.kernel.org, haustad@...co.com,
        jesus.sanchez-palencia@...el.com
Subject: Re: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to
 compile as module

From: Henrik Austad <henrik@...tad.us>
Date: Tue, 17 Oct 2017 12:10:10 +0200

> In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW
> traffic classes and misc IDs") sch_mqprio started using netdev_txq_to_tc
> to find the correct tc instead of dev->tc_to_txq[]
> 
> However, when mqprio is compiled as a module, it cannot resolve the
> symbol, leading to this error:
> 
>      ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined!
> 
> This adds an EXPORT_SYMBOL() since the other user in the kernel
> (netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a
> sysfs-callback.
> 
> Cc: Alexander Duyck <alexander.h.duyck@...el.com>
> Cc: Jesus Sanchez-Palencia <jesus.sanchez-palencia@...el.com>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Henrik Austad <haustad@...co.com>

Applied, thanks.