netdev - Re: [PATCH v3 0/6] adapt DPAA drivers for DSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171018.134504.1506752039585315800.davem@davemloft.net>
Date:   Wed, 18 Oct 2017 13:45:04 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     madalin.bucur@....com
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, junote@...look.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/6] adapt DPAA drivers for DSA

From: Madalin Bucur <madalin.bucur@....com>
Date: Mon, 16 Oct 2017 21:36:04 +0300

> Junote Cai reported that he was not able to get a DSA setup involving the
> DPAA/FMAN driver to work and narrowed it down to of_find_net_device_by_node()
> call in DSA setup. The initial attempt to fix this by adding of_node to the
> platform device results in a second, failed, probing of the FMan MAC driver
> against the new platform device created for the DPAA Ethernet driver.
> Solve these issues by removing the of_node pointer from the platform device
> and changing the net_dev dev to the of_device dev to ensure the DSA init
> will be able to find the DPAA net_dev using of_find_net_device_by_node().
> Several changes were required to enable this solution: refactoring the
> adjust_link (also resulted in lesser, cleaner code) and renaming the fman
> kernel modules to keep the legacy udev rules happy.
> 
> Changes in v2:
> 
>  - fix issue on error path in "dpaa_eth: change device used" patch
>  - cleanup the dpaa_eth_probe() error paths
> 
> Changes in v3:
> 
>  - remove obsolete comment in moved code
>  - add explanation for module rename

Series applied.