netdev - Re: [PATCH v2 net-next] tcp: Check daddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8f1c0c37-e39d-de47-f4f8-5d76e36ddfb1@gmail.com>
Date:   Wed, 18 Oct 2017 08:54:10 -0600
From:   David Ahern <dsahern@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com
Subject: Re: [PATCH v2 net-next] tcp: Check daddr_cache before use in
 tracepoint

On 10/18/17 7:15 AM, David Miller wrote:
> From: David Ahern <dsahern@...il.com>
> Date: Mon, 16 Oct 2017 15:32:07 -0700
> 
>> Running perf in one window to capture tcp_retransmit_skb tracepoint:
>>     $ perf record -e tcp:tcp_retransmit_skb -a
>>
>> And causing a retransmission on an active TCP session (e.g., dropping
>> packets in the receiver, changing MTU on the interface to 500 and back
>> to 1500) triggers a panic:
>  ...
>> Check that daddr_cache is non-NULL before de-referencing.
>>
>> Fixes: e086101b150a ("tcp: add a tracepoint for tcp retransmission")
>> Signed-off-by: David Ahern <dsahern@...il.com>
> 
> Applied.
> 

Hi Dave: There was a v3 to this one. I'll send a diff patch.