netdev - Re: [PATCH net-next] tcp: Remove use of inet6_sk and add IPv6 checks to tracepoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B63D9FF8-2BA1-43FC-B8A5-D3565EF545B6@fb.com>
Date:   Wed, 18 Oct 2017 16:27:52 +0000
From:   Song Liu <songliubraving@...com>
To:     Eric Dumazet <eric.dumazet@...il.com>
CC:     David Ahern <dsahern@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH net-next] tcp: Remove use of inet6_sk and add IPv6 checks
 to tracepoint


> On Oct 18, 2017, at 8:28 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> 
> On Wed, 2017-10-18 at 08:17 -0700, David Ahern wrote:
>> 386fd5da401d ("tcp: Check daddr_cache before use in tracepoint") was the
>> second version of the tracepoint fixup patch. This patch is the delta
>> between v2 and v3.  Specifically, remove the use of inet6_sk and check
>> sk_family as requested by Eric and add IS_ENABLED(CONFIG_IPV6) around
>> the use of sk_v6_rcv_saddr and sk_v6_daddr as done in sock_common (noted
>> by Cong).
>> 
>> Signed-off-by: David Ahern <dsahern@...il.com>
>> ---
> 
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> 
> Thanks !
> 

Tested-by: Song Liu <songliubraving@...com>