netdev - Re: [PATCH 2/2] liquidio: mark expected switch fall-through in octeon_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171018175357.GA14232@felix-thinkpad.cavium.com>
Date:   Wed, 18 Oct 2017 10:53:57 -0700
From:   Felix Manlunas <felix.manlunas@...ium.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     Derek Chickles <derek.chickles@...iumnetworks.com>,
        Satanand Burla <satananda.burla@...iumnetworks.com>,
        Felix Manlunas <felix.manlunas@...iumnetworks.com>,
        Raghu Vatsavayi <raghu.vatsavayi@...iumnetworks.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] liquidio: mark expected switch fall-through in
 octeon_destroy_resources

On Tue, Oct 17, 2017 at 02:01:45PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
> This code was tested by compilation only (GCC 7.2.0 was used).
> Please, verify if the actual intention of the code is to fall through.
> 
>  drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> index e4a112c..4c3b568 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> @@ -747,7 +747,7 @@ static void octeon_destroy_resources(struct octeon_device *oct)
>  
>  		if (lio_wait_for_oq_pkts(oct))
>  			dev_err(&oct->pci_dev->dev, "OQ had pending packets\n");
> -
> +		/* fall through */
>  	case OCT_DEV_INTR_SET_DONE:
>  		/* Disable interrupts  */
>  		oct->fn_list.disable_interrupt(oct, OCTEON_ALL_INTR);
> -- 
> 2.7.4
> 

Acked-by: Felix Manlunas <felix.manlunas@...ium.com>