netdev - Re: [PATCH v3] net: ftgmac100: Request clock and set speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171018.120929.1774171348326334992.davem@davemloft.net>
Date:   Wed, 18 Oct 2017 12:09:29 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     joel@....id.au
Cc:     benh@...nel.crashing.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, andrew@...id.au
Subject: Re: [PATCH v3] net: ftgmac100: Request clock and set speed

From: Joel Stanley <joel@....id.au>
Date: Fri, 13 Oct 2017 12:16:38 +0800

> According to the ASPEED datasheet, gigabit speeds require a clock of
> 100MHz or higher. Other speeds require 25MHz or higher. This patch
> configures a 100MHz clock if the system has a direct-attached
> PHY, or 25MHz if the system is running NC-SI which is limited to 100MHz.
> 
> There appear to be no other upstream users of the FTGMAC100 driver it is
> hard to know the clocking requirements of other platforms. Therefore a
> conservative approach was taken with enabling clocks. If the platform is
> not ASPEED, both requesting the clock and configuring the speed is
> skipped.
> 
> Signed-off-by: Joel Stanley <joel@....id.au>

Applied to net-next, thanks.