netdev - Re: [PATCH] wanxl: use m68k-linux-gnu-as if available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171018.130721.1208428223967129203.davem@davemloft.net>
Date:   Wed, 18 Oct 2017 13:07:21 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     kilobyte@...band.pl
Cc:     khc@...waw.pl, netdev@...r.kernel.org
Subject: Re: [PATCH] wanxl: use m68k-linux-gnu-as if available

From: Adam Borowski <kilobyte@...band.pl>
Date: Wed, 18 Oct 2017 13:33:26 +0200

> On Wed, Oct 18, 2017 at 12:08:12PM +0100, David Miller wrote:
>> From: Adam Borowski <kilobyte@...band.pl>
>> Date: Fri, 13 Oct 2017 01:24:34 +0200
>> 
>> > This fixes build failure on Debian based systems: GNU as is the only m68k
>> > assembler available in the archive (package binutils-m68k-linux-gnu).
>> > 
>> > Signed-off-by: Adam Borowski <kilobyte@...band.pl>
>> 
>> The Kconfig help text for the config option controlling the build
>> firmware is extremely clear what the requirements are for enabling
>> that option.
>> 
>> And that is: "It requires as68k, ld68k and hexdump programs."
> 
> Yeah, but as far as I know, as68k is a name of "GNU as"; Debian calls the
> same m68k-linux-gnu-as (and in general, $(GNU_TRIPLET)-as for all usual
> cross toolchains shipped).  And as Debian derivatives make the majority of
> distro installs these days, supporting its naming scheme would be
> convenient.
> 
> Or, if you believe no one should try to build this firmware from source,
> it might be better to annotate it to be excluded from randconfig builds.

We don't even know if whatever "as68k" is would be the same thing
as GNU as and generate the same binaries.

If you really must, somehow make sure the proper tools are available
at build or Kconfig time.