netdev - Re: [PATCH 1/5] net: virtio dynamically disable/enable LRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171019054432-mutt-send-email-mst@kernel.org>
Date:   Thu, 19 Oct 2017 05:47:30 +0300
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Caleb Raitto <caraitto@...gle.com>
Cc:     John Fastabend <john.fastabend@...il.com>, tgraf@...g.ch,
        shm@...ulusnetworks.com, alexei.starovoitov@...il.com,
        daniel@...earbox.net, davem@...emloft.net, netdev@...r.kernel.org,
        bblanco@...mgrid.com, brouer@...hat.com,
        Catherine Sullivan <csully@...gle.com>,
        Jason Wang <jasowang@...hat.com>
Subject: Re: [PATCH 1/5] net: virtio dynamically disable/enable LRO

On Wed, Oct 18, 2017 at 07:18:31PM -0700, Caleb Raitto wrote:
> On Fri, Nov 18, 2016 at 11:00 AM, John Fastabend
> <john.fastabend@...il.com> wrote:
> >
> > From: John Fastabend <john.fastabend@...il.com>
> > Date: Fri, Nov 18, 2016 at 11:00 AM
> > Subject: [PATCH 1/5] net: virtio dynamically disable/enable LRO
> > To: <tgraf@...g.ch>, <shm@...ulusnetworks.com>, <alexei.starovoitov@...il.com>, <daniel@...earbox.net>, <davem@...emloft.net>
> > Cc: <john.r.fastabend@...el.com>, <netdev@...r.kernel.org>, <bblanco@...mgrid.com>, <john.fastabend@...il.com>, <brouer@...hat.com>
> >
> > This adds support for dynamically setting the LRO feature flag. The
> > message to control guest features in the backend uses the
> > CTRL_GUEST_OFFLOADS msg type.
> > Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> > ---
> >  drivers/net/virtio_net.c |   43 +++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 43 insertions(+)
> > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > index 2cafd12..0758cae 100644
> > --- a/drivers/net/virtio_net.c
> > +++ b/drivers/net/virtio_net.c
> > @@ -1419,6 +1419,41 @@ static void virtnet_init_settings(struct net_device *dev)
> 
> Hi,
> 
> I work on Google Compute Engine, and I noticed that you had this
> unmerged patch that allows controlling offloads using ethtool for
> virtionet.
> 
> We are interested in merging this patch as it will be useful in
> debugging customer issues related to offloads and MTU.
> 
> If work remains to get the patch merged, I'm willing to help out.
> 
> Thanks,
> -Caleb

This patch needs to be rebased on top of latest patches by Jason.
In particular, there's code to disable/enable offloads automatically.
That either needs to go away if user configured them manually,
or the conflict resolved.

-- 
MST