netdev - Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32524.1508447816@warthog.procyon.org.uk>
Date:   Thu, 19 Oct 2017 22:16:56 +0100
From:   David Howells <dhowells@...hat.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     dhowells@...hat.com, "David S. Miller" <davem@...emloft.net>,
        linux-afs@...ts.infradead.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

Gustavo A. R. Silva <garsilva@...eddedor.com> wrote:

> +		/* fall through */

All new comments in rxrpc should begin with a capital letter; I'm switching to
this as I modify the lines with comments on.  Fix checkpatch or gcc or
whatever takes -Wimplicit-fallthrough to stop being silly.

> -		/* Fall through */
> -
> +		/* fall through */

No.  Firstly, it should be 'F'; secondly, don't remove the blank line - it's
there for a reason.

> +		/* fall through */

Capital 'F'.

> -
> +		/* fall through */

Don't remove the blank line.  Capital 'F'.

> +			/* fall through */

Capital 'F'.

David