netdev - Re: [net-next PATCH] macvlan/macvtap: Add support for L2 forwarding offloads with macvtap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171019.124424.463288330485082808.davem@davemloft.net>
Date:   Thu, 19 Oct 2017 12:44:24 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     alexander.h.duyck@...el.com
Cc:     netdev@...r.kernel.org
Subject: Re: [net-next PATCH] macvlan/macvtap: Add support for L2
 forwarding offloads with macvtap

From: Alexander Duyck <alexander.h.duyck@...el.com>
Date: Mon, 16 Oct 2017 22:44:44 -0400

> This patch reverts earlier commit b13ba1b83f52 ("macvlan: forbid L2
> fowarding offload for macvtap"). The reason for reverting this is because
> the original patch no longer fixes what it previously did as the
> underlying structure has changed for macvtap. Specifically macvtap
> originally pulled packets directly off of the lowerdev. However in commit
> 6acf54f1cf0a ("macvtap: Add support of packet capture on macvtap device.")
> that code was changed and instead macvtap would listen directly on the
> macvtap device itself instead of the lower device. As such, the L2
> forwarding offload should now be able to provide a performance advantage of
> skipping the checks on the lower dev while not introducing any sort of
> regression.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>

Applied.