netdev - Re: [PATCH] net/ethernet/sgi: Code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171019.132704.299365871401082792.davem@davemloft.net>
Date:   Thu, 19 Oct 2017 13:27:04 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     kumba@...too.org
Cc:     ralf@...ux-mips.org, linux-mips@...ux-mips.org,
        netdev@...r.kernel.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/ethernet/sgi: Code cleanup

From: Joshua Kinard <kumba@...too.org>
Date: Tue, 17 Oct 2017 13:54:30 -0400

> From: Joshua Kinard <kumba@...too.org>
> 
> The below patch attempts to clean up the code for the in-tree driver
> for IOC3 ethernet and serial console support, primarily used by SGI
> MIPS platforms.  Notable changes include:
> 
>   - Lots of whitespace cleanup
>   - Using shorthand integer types (u16, u32, etc) where appropriate

These seem to be arbitrary, "unsigned int" is a fine value for a
hash computation.

You're also making many different kinds of changes in one patch
which makes it very difficult to review.

This driver is also for such ancient hardware, that the risk
of potentially breaking the driver far outweighs the value of
"cleaning up" the code.