netdev - Re: [PATCH net-next] ipv6: let trace_fib6_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171021.022352.414024597933176809.davem@davemloft.net>
Date:   Sat, 21 Oct 2017 02:23:52 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, rostedt@...dmis.org, mingo@...hat.com,
        dsa@...ulusnetworks.com
Subject: Re: [PATCH net-next] ipv6: let trace_fib6_table_lookup()
 dereference the fib table

From: Paolo Abeni <pabeni@...hat.com>
Date: Thu, 19 Oct 2017 09:31:43 +0200

> The perf traces for ipv6 routing code show a relevant cost around
> trace_fib6_table_lookup(), even if no trace is enabled. This is
> due to the fib6_table de-referencing currently performed by the
> caller.
> 
> Let's the tracing code pay this overhead, passing to the trace
> helper the table pointer. This gives small but measurable
> performance improvement under UDP flood.
> 
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Looks good, applied.