netdev - Re: [PATCH] net: ethtool: remove error check for legacy setting transceiver type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171022.021514.303896603307493322.davem@davemloft.net>
Date:   Sun, 22 Oct 2017 02:15:14 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     niklas.soderlund+renesas@...natech.se
Cc:     f.fainelli@...il.com, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, geert@...ux-m68k.org,
        renjith.rv@...st-global.com
Subject: Re: [PATCH] net: ethtool: remove error check for legacy setting
 transceiver type

From: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Date: Fri, 20 Oct 2017 01:32:08 +0200

> Commit 9cab88726929605 ("net: ethtool: Add back transceiver type")
> restores the transceiver type to struct ethtool_link_settings and
> convert_link_ksettings_to_legacy_settings() but forgets to remove the
> error check for the same in convert_legacy_settings_to_link_ksettings().
> This prevents older versions of ethtool to change link settings.
> 
>     # ethtool --version
>     ethtool version 3.16
> 
>     # ethtool -s eth0 autoneg on speed 100 duplex full
>     Cannot set new settings: Invalid argument
>       not setting speed
>       not setting duplex
>       not setting autoneg
> 
> While newer versions of ethtool works.
> 
>     # ethtool --version
>     ethtool version 4.10
> 
>     # ethtool -s eth0 autoneg on speed 100 duplex full
>     [   57.703268] sh-eth ee700000.ethernet eth0: Link is Down
>     [   59.618227] sh-eth ee700000.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx
> 
> Fixes: 19cab88726929605 ("net: ethtool: Add back transceiver type")
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>

Applied.