netdev - Re: [net-next] tcp: do tcp_mstamp_refresh before retransmits on TSQ handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1508692270.30291.53.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Sun, 22 Oct 2017 10:11:10 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Koichiro Den <den@...ipeden.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, ncardwell@...gle.com
Subject: Re: [net-next] tcp: do tcp_mstamp_refresh before retransmits on TSQ
 handler

On Sun, 2017-10-22 at 09:49 -0700, Eric Dumazet wrote:

> Here is the test I cooked.
> 
> Note that it actually passes just fine, do I am wondering if your patch
> is needed after all..
> 

Oh this is because tcp_mstamp_refresh() is called from tcp_write_xmit()
and tcp_write_xmit() is directly called from tcp_tsq_handler()

So it looks your patch has no observable effect.

(Even with usec TS as we use here at Google, it has no effect since TCP
stack does not consider RTT samples being valid if skb was ever
retransmitted)