netdev - Re: [PATCH v2 net-next 0/6] add a set of tracepoints to tcp stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1CE9BEAA-1678-47E2-AD6A-038388E3AEB1@fb.com>
Date:   Mon, 23 Oct 2017 16:26:11 +0000
From:   Song Liu <songliubraving@...com>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "alexei.starovoitov@...il.com" <alexei.starovoitov@...il.com>,
        "liu.song.a23@...il.com" <liu.song.a23@...il.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        "hannes@...essinduktion.org" <hannes@...essinduktion.org>,
        "brendan.d.gregg@...il.com" <brendan.d.gregg@...il.com>,
        "ncardwell@...gle.com" <ncardwell@...gle.com>,
        David Ahern <dsahern@...il.com>,
        Kernel Team <Kernel-team@...com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>
Subject: Re: [PATCH v2 net-next 0/6] add a set of tracepoints to tcp stack

CCing key audience of these patches.

Thanks,
Song

> On Oct 23, 2017, at 9:20 AM, Song Liu <songliubraving@...com> wrote:
> 
> Changes from v1:
> 
> Fix build error (with ipv6 as ko) by adding EXPORT_TRACEPOINT_SYMBOL_GPL
> for trace_tcp_send_reset.
> 
> These patches add the following tracepoints to tcp stack.
> 
> tcp_send_reset
> tcp_receive_reset
> tcp_destroy_sock
> tcp_set_state
> 
> These tracepoints can be used to track TCP state changes. Such state
> changes include but are not limited to: connection establish,
> connection termination, tx and rx of RST, various retransmits.
> 
> Currently, we use the following kprobes to trace these events:
> 
> int kprobe__tcp_validate_incoming
> int kprobe__tcp_send_active_reset
> int kprobe__tcp_v4_send_reset
> int kprobe__tcp_v6_send_reset
> int kprobe__tcp_v4_destroy_sock
> int kprobe__tcp_set_state
> int kprobe__tcp_retransmit_skb
> 
> These tracepoints will help us simplify this work.
> 
> Thanks,
> Song
> 
> Song Liu (6):
>  tcp: add trace event class tcp_event_sk_skb
>  tcp: mark trace event arguments sk and skb as const
>  tcp: add tracepoint trace_tcp_send_reset
>  tcp: add tracepoint trace_tcp_receive_reset
>  tcp: add tracepoint trace_tcp_destroy_sock
>  tcp: add tracepoint trace_tcp_set_state()
> 
> include/trace/events/tcp.h | 181 ++++++++++++++++++++++++++++++++++++++++++++-
> net/core/net-traces.c      |   2 +
> net/ipv4/tcp.c             |   4 +
> net/ipv4/tcp_input.c       |   3 +
> net/ipv4/tcp_ipv4.c        |   8 +-
> net/ipv4/tcp_output.c      |   5 ++
> net/ipv6/tcp_ipv6.c        |  10 ++-
> 7 files changed, 206 insertions(+), 7 deletions(-)
> 
> --
> 2.9.5