netdev - Re: [PATCH net-next] net: dsa: check master device before put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871sltofm5.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
Date:   Mon, 23 Oct 2017 14:58:58 -0400
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next] net: dsa: check master device before put

Hi Florian, David,

Florian Fainelli <f.fainelli@...il.com> writes:

> On 10/23/2017 11:01 AM, Vivien Didelot wrote:
>> In the case of pdata, the dsa_cpu_parse function calls dev_put() before
>> making sure it isn't NULL. Fix this.
>> 
>> Fixes: 71e0bbde0d88 ("net: dsa: Add support for platform data")
>> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
>
> Did not you want to target 'net' for that though?

I wasn't sure if it was a good candidate for it.

If it is, David can you apply this patch on both trees or do you prefer
me to send a copy to -net?


Thanks,

        Vivien