netdev - Re: [PATCH net] tcp/dccp: fix lockdep splat in inet_csk_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171023.054627.999192892187895351.davem@davemloft.net>
Date:   Mon, 23 Oct 2017 05:46:27 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp/dccp: fix lockdep splat in inet_csk_route_req()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sun, 22 Oct 2017 12:33:57 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> This patch fixes the following lockdep splat in inet_csk_route_req()
> 
>   lockdep_rcu_suspicious
>   inet_csk_route_req
>   tcp_v4_send_synack
>   tcp_rtx_synack
>   inet_rtx_syn_ack
>   tcp_fastopen_synack_time
>   tcp_retransmit_timer
>   tcp_write_timer_handler
>   tcp_write_timer
>   call_timer_fn
> 
> Thread running inet_csk_route_req() owns a reference on the request
> socket, so we have the guarantee ireq->ireq_opt wont be changed or
> freed.
> 
> lockdep can enforce this invariant for us.
> 
> Fixes: c92e8c02fe66 ("tcp/dccp: fix ireq->opt races")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable.