netdev - Re: [PATCH] isdn/gigaset: Provide cardstate context for bas timer callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171023.031247.1142312234606249877.davem@davemloft.net>
Date:   Mon, 23 Oct 2017 03:12:47 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     keescook@...omium.org
Cc:     pebolle@...cali.nl, isdn@...ux-pingi.de, johan@...nel.org,
        linux-kernel@...r.kernel.org,
        gigaset307x-common@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH] isdn/gigaset: Provide cardstate context for bas timer
 callbacks

From: Kees Cook <keescook@...omium.org>
Date: Fri, 20 Oct 2017 13:47:08 -0700

> While the work callback uses the urb to find cardstate from bas_cardstate,
> this may not be valid for timer callbacks. Instead, introduce a direct
> pointer back to the cardstate from bas_cardstate for use in timer
> callbacks.
> 
> Reported-by: Paul Bolle <pebolle@...cali.nl>
> Fixes: 4cfea08e6251 ("isdn/gigaset: Convert timers to use timer_setup()")
> Cc: Paul Bolle <pebolle@...cali.nl>
> Cc: Karsten Keil <isdn@...ux-pingi.de>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Johan Hovold <johan@...nel.org>
> Cc: gigaset307x-common@...ts.sourceforge.net
> Cc: netdev@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>

Applied to net-next.