netdev - Re: [PATCH net-next] net/sched: Fix actions list corruption when adding offloaded tc flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171024.190119.318681859354315835.davem@davemloft.net>
Date:   Tue, 24 Oct 2017 19:01:19 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     ogerlitz@...lanox.com
Cc:     netdev@...r.kernel.org, mlxsw@...lanox.com, roid@...lanox.com,
        paulb@...lanox.com
Subject: Re: [PATCH net-next] net/sched: Fix actions list corruption when
 adding offloaded tc flows

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Tue, 24 Oct 2017 08:58:02 +0300

> Prior to commit b3f55bdda8df, the networking core doesn't wire an in-place
> actions list the when the low level driver is called to offload the flow,
> but all low level drivers do that (call tcf_exts_to_list()) in their
> offloading "add" logic.
> 
> Now, the in-place list is set in the core which goes over the list in a loop,
> but also by the hw driver when their offloading code is invoked indirectly:
> 
> 	cls_xxx add flow -> tc_setup_cb_call -> tc_exts_setup_cb_egdev_call -> hw driver
> 
> which messes up the core list instance upon driver return. Fix that by avoiding
> in-place list on the net core code that deals with adding flows.
> 
> Fixes: b3f55bdda8df ('net: sched: introduce per-egress action device callbacks')
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>

Applied.