netdev - Re: [PATCH v2 net] tcp/dccp: fix other lockdep splats accessing ireq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Oct 2017 20:17:52 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     kbuild-all@...org, kernel test robot <fengguang.wu@...el.com>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net] tcp/dccp: fix other lockdep splats accessing
 ireq_opt

Hi Eric,

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Eric-Dumazet/tcp-dccp-fix-other-lockdep-splats-accessing-ireq_opt/20171024-200038
config: i386-randconfig-x003-201743 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/srcu.h:33:0,
                    from include/linux/notifier.h:15,
                    from include/linux/memory_hotplug.h:6,
                    from include/linux/mmzone.h:779,
                    from include/linux/gfp.h:5,
                    from include/linux/mm.h:9,
                    from net/socket.c:61:
   include/net/inet_sock.h: In function 'ireq_opt_deref':
>> include/net/inet_sock.h:138:29: error: 'ireq' is a pointer; did you mean to use '->'?
             refcount_read(&ireq.req->rsk_refcnt) > 0);
                                ^
            ->
   include/linux/rcupdate.h:292:52: note: in definition of macro 'RCU_LOCKDEP_WARN'
      if (debug_lockdep_rcu_enabled() && !__warned && (c)) { \
                                                       ^
   include/linux/rcupdate.h:486:2: note: in expansion of macro '__rcu_dereference_check'
     __rcu_dereference_check((p), (c) || rcu_read_lock_held(), __rcu)
     ^~~~~~~~~~~~~~~~~~~~~~~
>> include/net/inet_sock.h:137:9: note: in expansion of macro 'rcu_dereference_check'
     return rcu_dereference_check(ireq->ireq_opt,
            ^~~~~~~~~~~~~~~~~~~~~

vim +138 include/net/inet_sock.h

   134	
   135	static inline struct ip_options_rcu *ireq_opt_deref(const struct inet_request_sock *ireq)
   136	{
 > 137		return rcu_dereference_check(ireq->ireq_opt,
 > 138					     refcount_read(&ireq.req->rsk_refcnt) > 0);
   139	}
   140	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29923 bytes)