netdev - Re: [PATCH v2 net] tcp/dccp: fix other lockdep splats accessing ireq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1508858313.30291.110.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 24 Oct 2017 08:18:33 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     fengguang.wu@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] tcp/dccp: fix other lockdep splats accessing
 ireq_opt

On Tue, 2017-10-24 at 18:56 +0900, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Mon, 23 Oct 2017 16:15:08 -0700
> 
> > +static inline struct ip_options_rcu *ireq_opt_deref(const struct inet_request_sock *ireq)
> > +{
> > +	return rcu_dereference_check(ireq->ireq_opt,
> > +				     refcount_read(&ireq.req->rsk_refcnt) > 0);
>                                                     ^^^^^^^^^
> 
> Eric, _please_ build test your changes properly.

Ah, you mean the compiler is not fixing this small error for us ? :)

Sorry :/