netdev - RE: [PATCH net-next 2/2] net: dsa: lan9303: Learn addresses on CPU port when bridged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9235D6609DB808459E95D78E17F2E43D40B889C8@CHN-SV-EXMX02.mchp-main.com>
Date:   Tue, 24 Oct 2017 17:18:30 +0000
From:   <Woojung.Huh@...rochip.com>
To:     <privat@...l-hjelmeland.no>, <andrew@...n.ch>,
        <vivien.didelot@...oirfairelinux.com>, <f.fainelli@...il.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next 2/2] net: dsa: lan9303: Learn addresses on CPU
 port when bridged

Hi Egil,

> +static inline int lan9303_tx_use_arl(struct dsa_port *dp, u8 *dest_addr)
> +{
> +	struct lan9303 *chip = dp->ds->priv;
> +
> +	return chip->is_bridged && !ether_addr_equal(dest_addr,
> eth_stp_addr);
> +}
> 
>  static struct sk_buff *lan9303_xmit(struct sk_buff *skb, struct net_device
> *dev)
>  {
> @@ -62,7 +80,10 @@ static struct sk_buff *lan9303_xmit(struct sk_buff *skb,
> struct net_device *dev)
> 
>  	lan9303_tag = (u16 *)(skb->data + 2 * ETH_ALEN);
>  	lan9303_tag[0] = htons(ETH_P_8021Q);
> -	lan9303_tag[1] = htons(dp->index | BIT(4));
> +	lan9303_tag[1] = lan9303_tx_use_arl(dp, skb->data) ?

How about using skb_mac_header(skb) than skb->data?

> +				LAN9303_TAG_TX_USE_ALR :
> +				dp->index |

Thanks.
Woojung