netdev - Re: [PATCH net-next 4/4] net: qualcomm: rmnet: Add support for GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b557f39a42f86307eb580b7c02fe8a0e@codeaurora.org>
Date:   Wed, 25 Oct 2017 12:00:18 -0600
From:   Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Tom Herbert <tom@...bertland.com>, davem@...emloft.net,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 4/4] net: qualcomm: rmnet: Add support for GRO

> You need to check return code and abort if memory could not be
> allocated.
> 
> There is a reason this helper has _init() prefix, it does not belong to
> _setup() since a _setup() is not expected to fail.
> 
> Please take a look at other gro_cells_init() callers, and you will
> notice that it is called from ndo_init()
> 
> You might have copied the only buggy caller (vxlan).
> 
> Tom, if you read me fix vxlan, thanks !

Hi Eric

Thanks for pointing this out. I'll change this in v2.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project