netdev - Re: [PATCH net-next v2 2/2] bridge: vlan: signal if anything changed on vlan add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Oct 2017 04:51:12 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        roopa@...ulusnetworks.com, dsa@...ulusnetworks.com,
        mrv@...atatu.com, stephen@...workplumber.org,
        bridge@...ts.linux-foundation.org,
        Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Subject: Re: [PATCH net-next v2 2/2] bridge: vlan: signal if anything changed
 on vlan add

Hi Nikolay,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/bridge-make-setlink-dellink-notifications-more-accurate/20171026-042029
config: x86_64-randconfig-x019-201743 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   net/bridge/br_netlink.c: In function 'br_vlan_info':
>> net/bridge/br_netlink.c:520:10: error: too many arguments to function 'nbp_vlan_add'
       err = nbp_vlan_add(p, vinfo->vid, vinfo->flags,
             ^~~~~~~~~~~~
   In file included from net/bridge/br_netlink.c:21:0:
   net/bridge/br_private.h:931:19: note: declared here
    static inline int nbp_vlan_add(struct net_bridge_port *port, u16 vid, u16 flags)
                      ^~~~~~~~~~~~
>> net/bridge/br_netlink.c:524:10: error: too many arguments to function 'br_vlan_add'
       err = br_vlan_add(br, vinfo->vid, vinfo->flags,
             ^~~~~~~~~~~
   In file included from net/bridge/br_netlink.c:21:0:
   net/bridge/br_private.h:908:19: note: declared here
    static inline int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags)
                      ^~~~~~~~~~~

vim +/nbp_vlan_add +520 net/bridge/br_netlink.c

   507	
   508	static int br_vlan_info(struct net_bridge *br, struct net_bridge_port *p,
   509				int cmd, struct bridge_vlan_info *vinfo, bool *changed)
   510	{
   511		bool curr_change;
   512		int err = 0;
   513	
   514		switch (cmd) {
   515		case RTM_SETLINK:
   516			if (p) {
   517				/* if the MASTER flag is set this will act on the global
   518				 * per-VLAN entry as well
   519				 */
 > 520				err = nbp_vlan_add(p, vinfo->vid, vinfo->flags,
   521						   &curr_change);
   522			} else {
   523				vinfo->flags |= BRIDGE_VLAN_INFO_BRENTRY;
 > 524				err = br_vlan_add(br, vinfo->vid, vinfo->flags,
   525						  &curr_change);
   526			}
   527			if (curr_change)
   528				*changed = true;
   529			break;
   530	
   531		case RTM_DELLINK:
   532			if (p) {
   533				if (!nbp_vlan_delete(p, vinfo->vid))
   534					*changed = true;
   535	
   536				if ((vinfo->flags & BRIDGE_VLAN_INFO_MASTER) &&
   537				    !br_vlan_delete(p->br, vinfo->vid))
   538					*changed = true;
   539			} else if (!br_vlan_delete(br, vinfo->vid)) {
   540				*changed = true;
   541			}
   542			break;
   543		}
   544	
   545		return err;
   546	}
   547	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (21550 bytes)