netdev - Re: [PATCH net 5/6] rtnetlink: check DO_SETLINK_NOTIFY correctly in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <200b14af-97eb-426e-8b82-3e5114e7bd1b@gmail.com>
Date:   Thu, 26 Oct 2017 08:59:47 -0600
From:   David Ahern <dsahern@...il.com>
To:     nicolas.dichtel@...nd.com, vyasevic@...hat.com,
        Xin Long <lucien.xin@...il.com>,
        network dev <netdev@...r.kernel.org>
Cc:     davem@...emloft.net, hannes@...essinduktion.org
Subject: Re: [PATCH net 5/6] rtnetlink: check DO_SETLINK_NOTIFY correctly in
 do_setlink

On 10/26/17 1:41 AM, Nicolas Dichtel wrote:
>> So I found this the first timer around when looking at this code, but was told that
>> notification are expected anytime we modified any setting thus the code was simply
>> checking for MODIFIED bit.  Has that thinking changed?
> No, you're right, thank you for pointing this out. I was focus on the duplicated
> notifications and forget the initial goal.
> 
> I will ask for a revert.

For everyone of the MODIFIED but not NOTIFY is there already a message
sent? If so, no revert is needed. If not, then perhaps those need the
NOTIFY bit set.