netdev - Re: [PATCH net-next 3/3] mlxsw: spectrum_router: Return extack message on abort due to fib rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3dcd4a80-d94f-19a2-3238-49d329af1b60@gmail.com>
Date:   Thu, 26 Oct 2017 09:30:50 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, idosch@...lanox.com,
        johannes.berg@...el.com
Subject: Re: [PATCH net-next 3/3] mlxsw: spectrum_router: Return extack
 message on abort due to fib rules

On 10/26/17 12:38 AM, Ido Schimmel wrote:
> 
> Nice idea, but one problem is that the FIB notifier is atomic and thus
> when you trigger abort you end up sleeping in an atomic context:
> 
...

> 
> How about we keep the checking and error reporting inline, but do the
> actual abort in a workqueue?

yep. Will spin a v2.