netdev - Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 6/6] i40e: Enable cloud filters via tc-flower

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28335085-cc51-85a5-d602-4ae9d1e1088c@oracle.com>
Date:   Thu, 26 Oct 2017 14:35:41 -0700
From:   Shannon Nelson <shannon.nelson@...cle.com>
To:     "Nambiar, Amritha" <amritha.nambiar@...el.com>,
        intel-wired-lan@...osl.org
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 6/6] i40e: Enable
 cloud filters via tc-flower

On 10/26/2017 2:29 PM, Nambiar, Amritha wrote:
> On 10/11/2017 4:30 PM, Shannon Nelson wrote:
>> On 10/10/2017 5:24 PM, Amritha Nambiar wrote:

[...]

>>> +		/* For Geneve, the VNI should be placed in offset shifted by a
>>> +		 * byte than the offset for the Tenant ID for rest of the
>>
>> This comment isn't quite clear - maybe s/than/then/ ?
> 
> How about, "For Geneve, the VNI should begin at an offset shifted by a
> byte compared to the offset normally used for the Tenant ID for other
> tunnel types" ?

Or maybe "Due to hardware eccentricities, the VNI for Geneve is shifted 
one more byte further than normally used for Tenant ID in other tunnel 
types"

[...]

>>> +				dev_err(&pf->pdev->dev, "Bad src port mask 0x%04x\n",
>>
>> Consider using %pI4
> 
> For ports, I'll keep the 0x%04x. I'll change to %pI4 for the IPv4
> address masks.

Oh, right, that one's a port.

sln