netdev - Re: [PATCH net-next 3/9] net: dsa: fix dsa_is_normal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64885aa8-424a-baba-e2a7-9178d3363d73@gmail.com>
Date:   Thu, 26 Oct 2017 16:08:42 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next 3/9] net: dsa: fix dsa_is_normal_port helper

On 10/26/2017 08:22 AM, Vivien Didelot wrote:
> In order to know if a port is of type user, dsa_is_normal_port checks
> that the given port is not of type DSA nor CPU. This is not enough
> because a port can be unused.
> 
> Without the previous fix, this caused the unused mv88e6xxx ports to be
> configured in normal mode.
> 
> The ds->enabled_port_mask reports the user ports, so check this instead.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian