netdev - Re: [PATCH net] tcp: call tcp_rate_skb_sent() when retransmit with unaligned skb->data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171026.175106.59899352471128775.davem@davemloft.net>
Date:   Thu, 26 Oct 2017 17:51:06 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     ysseung@...gle.com
Cc:     netdev@...r.kernel.org, ncardwell@...gle.com, soheil@...gle.com
Subject: Re: [PATCH net] tcp: call tcp_rate_skb_sent() when retransmit with
 unaligned skb->data

From: Yousuk Seung <ysseung@...gle.com>
Date: Tue, 24 Oct 2017 16:44:42 -0700

> Current implementation calls tcp_rate_skb_sent() when tcp_transmit_skb()
> is called when it clones skb only. Not calling tcp_rate_skb_sent() is OK
> for all such code paths except from __tcp_retransmit_skb() which happens
> when skb->data address is not aligned. This may rarely happen e.g. when
> small amount of data is sent initially and the receiver partially acks
> odd number of bytes for some reason, possibly malicious.
> 
> Signed-off-by: Yousuk Seung <ysseung@...gle.com>
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Acked-by: Eric Dumazet <edumazet@...gle.com>

This doesn't apply to any of m trees.