netdev - Re: [Patch net 01/16] net_sched: introduce a workqueue for RCU callbacks of tc filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1509119524.11887.38.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Fri, 27 Oct 2017 08:52:04 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Chris Mi <chrism@...lanox.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jiri Pirko <jiri@...nulli.us>,
        John Fastabend <john.fastabend@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [Patch net 01/16] net_sched: introduce a workqueue for RCU
 callbacks of tc filter

On Fri, 2017-10-27 at 08:37 -0700, Cong Wang wrote:
> On Thu, Oct 26, 2017 at 9:39 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> > On Thu, 2017-10-26 at 21:28 -0700, Cong Wang wrote:
> >> On Thu, Oct 26, 2017 at 9:05 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> >> Paul pointed out the same.
> >>
> >> As I replied, this rcu_barrier() is NOT added by this patchset, it is already
> >> there in current master branch.
> >
> > You added the rtnl_lock()  rtnl_unlock()...
> 
> 
> Unfortunately you are wrong again, tcf_block_put() holds RTNL
> in current code as well...

Then current code must be fixed, without adding more crap.

> 

> What stops you to optimize current code?

I might be forced to do so, eventually.