netdev - Re: [net PATCH 2/2] bpf: rename sk_actions to align with bpf infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Oct 2017 12:44:22 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        daniel@...earbox.net
Subject: Re: [net PATCH 2/2] bpf: rename sk_actions to align with bpf
 infrastructure

On Fri, Oct 27, 2017 at 09:45:53AM -0700, John Fastabend wrote:
> Recent additions to support multiple programs in cgroups impose
> a strict requirement, "all yes is yes, any no is no". To enforce
> this the infrastructure requires the 'no' return code, SK_DROP in
> this case, to be 0.
> 
> To apply these rules to SK_SKB program types the sk_actions return
> codes need to be adjusted.
> 
> This fix adds SK_PASS and makes 'SK_DROP = 0'. Finally, remove
> SK_ABORTED to remove any chance that the API may allow aborted
> program flows to be passed up the stack. This would be incorrect
> behavior and allow programs to break existing policies.
> 
> Signed-off-by: John Fastabend <john.fastabend@...il.com>

Acked-by: Alexei Starovoitov <ast@...nel.org>